This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Marco Sulla
Recipients Marco Sulla, Mark.Shannon, methane, serhiy.storchaka
Date 2020-10-31.16:34:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1604162082.0.0.462696486235.issue41835@roundup.psfhosted.org>
In-reply-to
Content
Well, actually Serhiy is right, it does not seem that the macro benchs did show something significant. Maybe the code can be used in other parts of CPython, for example in _pickle, where dicts are loaded. But it needs also to expose, maybe internally only, dictresize() and DICT_NEXT_VERSION(). Not sure it's something desirable.

There's something that I do not understand: the speedup to unpack_sequence. I checked the pyperformance code, and it's a microbench for:

a, b = some_sequence

It should *not* be affected by the change. Anyway, I run the bench other 10 times, and the lowest value with the CPython code without the PR is not lower than 67.7 ns. With the PR, it reaches 53.5 ns. And I do not understand why. Maybe it affects the creation of the dicts with the local and global vars?
History
Date User Action Args
2020-10-31 16:34:42Marco Sullasetrecipients: + Marco Sulla, methane, Mark.Shannon, serhiy.storchaka
2020-10-31 16:34:42Marco Sullasetmessageid: <1604162082.0.0.462696486235.issue41835@roundup.psfhosted.org>
2020-10-31 16:34:41Marco Sullalinkissue41835 messages
2020-10-31 16:34:41Marco Sullacreate