Message 379799 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	corona10, rhettinger, vstinner
Date	2020-10-27.20:32:54
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1603830774.87.0.273837313385.issue42161@roundup.psfhosted.org>
In-reply-to

Content
> Why did you put _PyLong_GetOne() inside the loop for the fast path and outside the loop for the slow path? Oh, I didn't notice that the first part was also a loop. I wrote PR 23008 to move the call out of the loop. I tried to avoid calling the function if it's possible that the variable it not used. But here, it's always used, so it's relevant to move the loop invariant out of the loop ;-)

> Why did you put _PyLong_GetOne() inside the loop for the fast path and outside the loop for the slow path?

Oh, I didn't notice that the first part was also a loop. I wrote PR 23008 to move the call out of the loop.

I tried to avoid calling the function if it's possible that the variable it not used. But here, it's always used, so it's relevant to move the loop invariant out of the loop ;-)

History
Date	User	Action	Args
2020-10-27 20:32:54	vstinner	set	recipients: + vstinner, rhettinger, corona10
2020-10-27 20:32:54	vstinner	set	messageid: <1603830774.87.0.273837313385.issue42161@roundup.psfhosted.org>
2020-10-27 20:32:54	vstinner	link	issue42161 messages
2020-10-27 20:32:54	vstinner	create