Author barry
Recipients barry, lukasz.langa, ncoghlan, ned.deily, r.david.murray, sim0n, timb07
Date 2020-10-23.18:42:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1603478552.95.0.152896329609.issue30681@roundup.psfhosted.org>
In-reply-to
Content
Aside: I noticed that on _parseaddr.py:68, there's a bare `return`.  That should really be `return None` (EIBTI).  Can you fix that in your PR?

I think it's confusing to raise both TypeError and ValueError.  I suggest we check the `None` return from _parsedate_tz() and raise ValueError explicitly in that case, avoiding the implicit TypeError on the failing tuple unpack.

+1 on removing the mention of returning None from the documentation.  Then with the above, it would document raising ValueError on invalid date input.

As for backporting, I'm nosing Ned and Ɓukasz to weigh in.  Given that the patch is adding a new defect class (which it should), this won't break existing code, but it does mean that existing code would have different semantics depending on the patch version release of 3.9, 3.8, and 3.7.  I'm not completely comfortable with that, but let's see what the RMs say.  I guess I'm currently -0 on backporting.
History
Date User Action Args
2020-10-23 18:42:32barrysetrecipients: + barry, ncoghlan, ned.deily, r.david.murray, lukasz.langa, sim0n, timb07
2020-10-23 18:42:32barrysetmessageid: <1603478552.95.0.152896329609.issue30681@roundup.psfhosted.org>
2020-10-23 18:42:32barrylinkissue30681 messages
2020-10-23 18:42:32barrycreate