Author akuchling
Recipients akuchling
Date 2020-10-20.19:17:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
During the 3.10 development process, a call to `sys.audit()` got accidentally removed from the glob module. No tests caught it.

This is clearly bad. sys.audit() is intended for security-related purposes and can result in operations being cancelled, so someone may be relying on a particular event being triggered to catch a risky situation. If we then accidentally remove the audit event, that's a security hole.

The test suite should be verifying that audit events get triggered when we expect.  Presumably we'll need some kind of context manager or assertion that will do something like: 

  with self.assertAuditEventTriggered('glob.glob', 'path'):    
Date User Action Args
2020-10-20 19:17:14akuchlingsetrecipients: + akuchling
2020-10-20 19:17:14akuchlingsetmessageid: <>
2020-10-20 19:17:14akuchlinglinkissue42098 messages
2020-10-20 19:17:14akuchlingcreate