Message378879
In general, we don't accept patches like this:
* It risks breaks (in fact the tests are failing.
* We're not apply Black's quoting preferences to existing files.
* We're not yet adding type annotations through out.
* The PR introduces multiple new dependencies on other modules.
This tends to slow down load time and complicate maintenance.
* There are subtle changes to the logic and API because
of the dataclasses, cached_property, and lru_cache.
* We want to avoid code churn because it reduces stability
and because it complicates maintenance (making it harder to
apply fixes across versions).
Thank you for the suggestion, but we'll decline. |
|
Date |
User |
Action |
Args |
2020-10-18 17:38:24 | rhettinger | set | recipients:
+ rhettinger, alex.briskin |
2020-10-18 17:38:23 | rhettinger | set | messageid: <1603042703.97.0.704779272489.issue42069@roundup.psfhosted.org> |
2020-10-18 17:38:23 | rhettinger | link | issue42069 messages |
2020-10-18 17:38:23 | rhettinger | create | |
|