Author pablogsal
Recipients brandtbucher, nascheme, pablogsal, tim.peters
Date 2020-10-14.17:30:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1602696644.77.0.187495295489.issue41984@roundup.psfhosted.org>
In-reply-to
Content
Thanks a lot, Brandt for doing the benchmarking!

I think that unpack_sequence is **very** affected by code locality. I was debugging it recently with Linux perf (https://perf.wiki.kernel.org/index.php/Main_Page) and it shows that is extremely affected by L1-L2 cache performance. I still need to understand why, but yeah, I am fine ignoring it.

>All things considered, I believe we should fix this... I personally view memory leaks as second only to crashes and incorrect behavior in terms of severity.

Yeah, I very much agree with you. Could you convert your patch into a PR?
History
Date User Action Args
2020-10-14 17:30:44pablogsalsetrecipients: + pablogsal, tim.peters, nascheme, brandtbucher
2020-10-14 17:30:44pablogsalsetmessageid: <1602696644.77.0.187495295489.issue41984@roundup.psfhosted.org>
2020-10-14 17:30:44pablogsallinkissue41984 messages
2020-10-14 17:30:44pablogsalcreate