This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jaraco
Recipients bustawin, jaraco, xtreak
Date 2020-09-22.14:09:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1600783747.02.0.841488051195.issue40564@roundup.psfhosted.org>
In-reply-to
Content
I've also created this alternative to option 2:

- https://github.com/jaraco/zipp/tree/bugfix/bpo-40564-mixin

This alternative approach uses a mix-in rather than subclasses, creating a new class on-demand. I was hoping this approach would enable just augmenting the instance rather than affecting `source.__class__`, but when I got to the implementation, I found that `source.__class__` had to be mutated regardless.

This approach does have an advantage over option 2 in that it would support other ZipFile subclasses for source. It has the disadvantage in that it creates a new subclass for every instance created.

I've thought about it a lot and while I'm not particularly happy with any of the approaches, I'm leaning toward option 2.
History
Date User Action Args
2020-09-22 14:09:07jaracosetrecipients: + jaraco, xtreak, bustawin
2020-09-22 14:09:07jaracosetmessageid: <1600783747.02.0.841488051195.issue40564@roundup.psfhosted.org>
2020-09-22 14:09:07jaracolinkissue40564 messages
2020-09-22 14:09:06jaracocreate