This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vitaly.krug
Recipients ammar2, rhettinger, vitaly.krug
Date 2020-09-05.20:17:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CALVBdqvZknO0iuR-RHkbjZQmAduYTau0z_QgOzG-rqSuUakBLA@mail.gmail.com>
In-reply-to <1599336161.88.0.939436877914.issue38240@roundup.psfhosted.org>
Content
Well, when you do tab-completion in unit tests on `self.` and
`assertCountEqual` pops up, it sure sounds a lot like it's going to compare
just the count of the items. The point is that the name of the function is
not self-documenting, hence "misleading".

A better name could be `assertItemsEqual` or `assertCountAndItemsEqual`

On Sat, Sep 5, 2020 at 1:02 PM Raymond Hettinger <report@bugs.python.org>
wrote:

>
> Raymond Hettinger <raymond.hettinger@gmail.com> added the comment:
>
> This should stay closed as a duplicate.
>
> If you must, reopen of the original 27071, but it was closed for a
> reason.  The majority of respondents voted for the status quo.  Each
> alternative that was considered had its own share of problems.
>
> BTW, it is hyperbolic to call the name "horribly misleading".  The method
> literally runs Counter and checks for equality.  The docstring is clear
> about this:
>
>     def assertCountEqual(self, first, second, msg=None):
>         """Asserts that two iterables have the same elements, the same
> number of
>         times, without regard to order.
>
>             self.assertEqual(Counter(list(first)),
>                              Counter(list(second)))
>
>          Example:
>             - [0, 1, 1] and [1, 0, 1] compare equal.
>             - [0, 0, 1] and [0, 1] compare unequal.
>
>         """
>
> ----------
> nosy: +rhettinger
> status: open -> closed
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <https://bugs.python.org/issue38240>
> _______________________________________
>
History
Date User Action Args
2020-09-05 20:17:41vitaly.krugsetrecipients: + vitaly.krug, rhettinger, ammar2
2020-09-05 20:17:41vitaly.kruglinkissue38240 messages
2020-09-05 20:17:41vitaly.krugcreate