This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author rhettinger
Recipients Jeffrey.Kintscher, mark.dickinson, pablogsal, rhettinger, tim.peters, veky
Date 2020-08-06.04:43:35
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1596689015.41.0.729851851597.issue41458@roundup.psfhosted.org>
In-reply-to
Content
Here's variant (minimally tested) that has a fast path for the common case (no overflow or underflow), that uses a list instead of a deque, that keeps memory use small (only storing pending values that can't be combined without triggering an overflow or underflow).

----------------------------

from math import fabs, prod, isfinite

def product(seq, start=1.0):
    total = start
    s = []                 # values that would overflow the total
    s_side = False         # true if s_i increase the magnitude of the product
    for x in seq:
        old_total = total
        total *= x
        underflow = not total and old_total and not x
        if isfinite(total) and not underflow:
            continue       # fast-path for multiplies that doesn't overflow/underflow
        total = old_total

        side = fabs(x) > 1.0
        if not s or side == s_side:
            s.append(x)
            s_side = side
            continue

        t = [x, total]
        while s and t:      # opposite sides:  matter and antimatter
            x = s.pop() * t.pop()
            side = fabs(x) > 1.0
            s.append(x) if side == s_side else t.append(y)
        if t:
            s = t
            s_side = not s_side
        total = s.pop()
    return prod(s, start=total)
History
Date User Action Args
2020-08-06 04:43:35rhettingersetrecipients: + rhettinger, tim.peters, mark.dickinson, veky, pablogsal, Jeffrey.Kintscher
2020-08-06 04:43:35rhettingersetmessageid: <1596689015.41.0.729851851597.issue41458@roundup.psfhosted.org>
2020-08-06 04:43:35rhettingerlinkissue41458 messages
2020-08-06 04:43:35rhettingercreate