Author serhiy.storchaka
Recipients larry, rhettinger, serhiy.storchaka
Date 2020-07-18.14:33:13
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1595082793.92.0.490500501555.issue41333@roundup.psfhosted.org>
In-reply-to
Content
The proposed PR converts OrderedDict.pop() to Argument Clinic. It makes it 2 times faster.

$ ./python -m pyperf timeit -q --compare-to=../cpython-release2/python -s "from collections import OrderedDict; od = OrderedDict()" "od.pop('x', None)"
Mean +- std dev: [/home/serhiy/py/cpython-release2/python] 119 ns +- 2 ns -> [/home/serhiy/py/cpython-release/python] 56.3 ns +- 1.2 ns: 2.12x faster (-53%)

It was not converted before because Argument Clinic generated incorrect signature for it. It still is not able to generate correct signature, but at least it does not generate incorrect signature. And we now have other reason for using Argument Clinic -- performance.
History
Date User Action Args
2020-07-18 14:33:13serhiy.storchakasetrecipients: + serhiy.storchaka, rhettinger, larry
2020-07-18 14:33:13serhiy.storchakasetmessageid: <1595082793.92.0.490500501555.issue41333@roundup.psfhosted.org>
2020-07-18 14:33:13serhiy.storchakalinkissue41333 messages
2020-07-18 14:33:13serhiy.storchakacreate