Author rhettinger
Recipients lukasz.langa, petr.viktorin, pitrou, rhettinger, serhiy.storchaka, skrah, vstinner
Date 2020-07-07.18:37:19
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1594147039.64.0.346391564559.issue39542@roundup.psfhosted.org>
In-reply-to
Content
Victor, is there any reason PyType_GetFlags() can't be converted to a macro or an inlined function?  That seems like a simple and robust fix that won't get in the way of anything else you're doing.

We shouldn't disregard macOS timings. It is an important platform —dominant in data science, dominant among most of my clients, and dominant among the core developers at the last sprint.

None of the inlining should depend on LTO and PGO.  That is fragile and will create hard-to-explain variations between builds (even consecutive builds on the same platform).  Third-party extensions, SO and DLL files won't benefit from that.  Also, it makes it difficult to individually optimize and analyze a function without a costly rebuild at every step.
History
Date User Action Args
2020-07-07 18:37:19rhettingersetrecipients: + rhettinger, pitrou, vstinner, petr.viktorin, skrah, lukasz.langa, serhiy.storchaka
2020-07-07 18:37:19rhettingersetmessageid: <1594147039.64.0.346391564559.issue39542@roundup.psfhosted.org>
2020-07-07 18:37:19rhettingerlinkissue39542 messages
2020-07-07 18:37:19rhettingercreate