Author scoder
Recipients Matthias Braun, gvanrossum, petr.viktorin, scoder
Date 2020-06-20.11:16:56
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1592651816.97.0.57328835321.issue39960@roundup.psfhosted.org>
In-reply-to
Content
I ran into this, too. I agree that the "hackcheck" loop on heap types is probably wrong.

https://github.com/python/cpython/blob/04fc4f2a46b2fd083639deb872c3a3037fdb47d6/Objects/typeobject.c#L5947-L5977

It was written at a time (Py2.3?) when (practically) only Python implemented types were heap types, not extension types. I think what it tried to do was to find the builtin base type of a Python type, and check that no-one played tricks on the C slot functions of that C implemented type. With extension types implemented as heap types, having a different slot function in there is a perfectly valid thing.

I'll call in a couple of people since I'm also not sure how to fix the "hackcheck".

I'll also leave Py3.7 in the list of affected Python versions since we still have a short week before its final non-secfix-release. :)
History
Date User Action Args
2020-06-20 11:16:57scodersetrecipients: + scoder, gvanrossum, petr.viktorin, Matthias Braun
2020-06-20 11:16:56scodersetmessageid: <1592651816.97.0.57328835321.issue39960@roundup.psfhosted.org>
2020-06-20 11:16:56scoderlinkissue39960 messages
2020-06-20 11:16:56scodercreate