Author inada.naoki
Recipients Arfrever, andyma, docs@python, ezio.melotti, inada.naoki, miss-islington, mjacob, ncoghlan, pitrou, sreepriya
Date 2020-06-18.11:19:04
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAEfz+Ty5fxXznyNowhtE9FJFYUih9qMJrqF5BhQz01+-X6ccrg@mail.gmail.com>
In-reply-to <1592473709.53.0.415596353771.issue17110@roundup.psfhosted.org>
Content
>
> Manuel Jacob <me@manueljacob.de> added the comment:
>
> If the encoding supports it, since which Python version do
> Py_DecodeLocale() and os.fsencode() roundtrip?
>

Maybe, since Python 3.2. FWIW, fsencode is added by Victor in
https://bugs.python.org/issue8514

> The background of my question is that Mercurial goes some extra rounds to
> determine the correct encoding to emulate what Py_EncodeLocale() would do:
> https://www.mercurial-scm.org/repo/hg/file/5.4.1/mercurial/pycompat.py#l157
> . If os.fsencode() could be used, it would simplify the code. Mercurial
> supports Python 3.5+.
>
>
>

I think it is a right approach.
One of the important use case of os.fsencode is using file path from
sys.argv even if it can not be decoded by filesystem encoding.
History
Date User Action Args
2020-06-18 11:19:04inada.naokisetrecipients: + inada.naoki, ncoghlan, pitrou, ezio.melotti, Arfrever, docs@python, mjacob, sreepriya, andyma, miss-islington
2020-06-18 11:19:04inada.naokilinkissue17110 messages
2020-06-18 11:19:04inada.naokicreate