Message371492
> Last question before PR pls: given the fact that this test is to cover a fixed case when loop.sock_*() was hanging forever, should I keep the wait_for(..., timeout=10)?
For now, I think we can keep the asyncio.wait_for() w/ 10 the sec timeout. I'll have to run the tests locally though w/ the patch to double check (once the PR is opened), and it may still end up needing to be increased if the test fails again in the future. It should be okay though. |
|
Date |
User |
Action |
Args |
2020-06-14 06:45:04 | aeros | set | recipients:
+ aeros, vstinner, fantix, ned.deily, asvetlov, abacabadabacaba, lukasz.langa, yselivanov, achimnol, miss-islington |
2020-06-14 06:45:04 | aeros | set | messageid: <1592117104.52.0.725272536213.issue30064@roundup.psfhosted.org> |
2020-06-14 06:45:04 | aeros | link | issue30064 messages |
2020-06-14 06:45:04 | aeros | create | |
|