Author aeros
Recipients abacabadabacaba, achimnol, aeros, asvetlov, fantix, lukasz.langa, miss-islington, ned.deily, vstinner, yselivanov
Date 2020-06-14.01:14:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1592097280.85.0.419527265307.issue30064@roundup.psfhosted.org>
In-reply-to
Content
I believe that I might have identified a simple fix for the issue, but first I'd like to clarify on something:

What exactly is the reason that we need to use asyncio.wait_for() with a timeout of 10 seconds in these tests? We typically avoid using short duration timeouts on individual tests, largely because we don't want them to fail based on the performance of the device they're ran on. This can be a concern for slower devices running the test suite w/ parallel jobs.

If asyncio.wait_for() is necessary in this case, I'd advise increasing the timeout substantially. I didn't experiment with a wide variety of numbers, but increasing the duration from 10 to 60 seconds seems to have fixed the failure locally, so that might be a decent starting point. If it's not necessary, I'd prefer to simply remove the asyncio.wait_for()s in test_sock_client_racing.
History
Date User Action Args
2020-06-14 01:14:40aerossetrecipients: + aeros, vstinner, fantix, ned.deily, asvetlov, abacabadabacaba, lukasz.langa, yselivanov, achimnol, miss-islington
2020-06-14 01:14:40aerossetmessageid: <1592097280.85.0.419527265307.issue30064@roundup.psfhosted.org>
2020-06-14 01:14:40aeroslinkissue30064 messages
2020-06-14 01:14:40aeroscreate