Author orsenthil
Recipients Björn.Lindqvist, Chris Dent, Tim.Graham, benjamin.peterson, lukasz.langa, martin.panter, mgorny, miss-islington, ned.deily, orsenthil, r.david.murray, roguelazer
Date 2020-06-08.17:16:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1591636601.6.0.614336066997.issue27657@roundup.psfhosted.org>
In-reply-to
Content
Hi All,

On the previous message.

> I plan to address that point raised in this issue and close this ticket.

My intention was to close the bug.

1) The Issue was originally a regression in 3.8, and 3.7, And this been be resolved.


The change introduced did alter the behavior, but it was actually the correct one as I wrote

"For 3.9. - I am ready to defend the patch even at the cost of the breaking of the parsing of undefined behavior.  We should keep it. The patch simplifies a lot of corner cases and fixes the reported bugs. We don't guarantee backward compatibility between major versions, so I assume users will be careful when relying upon this undefined behavior and will take corrective action on their side before upgrading to 3.9.

We want patch releases to be backward compatible. That was the
user-complaint."

I agree with Ned Deily, that there are plenty of corner cases with urlparse APIs (Ref: https://bugs.python.org/issue36338#msg355322) 

That making any change is difficult (especially if not caught by regression suite).

*And if we simplify the code, it will be welcome, and will help us continue with next changes* - This was the original motivation of this code acceptance (Here https://github.com/python/cpython/commit/5a88d50ff013a64fbdb25b877c87644a9034c969 and https://bugs.python.org/issue27657#msg289557)

I was not very explicit on stance proposal previously, and assumed if anything else can be done. But No. I think, this behavior we want in Python3.9 (as discussed in the initial messages of this ticket).

I apologize, Michał that I missed responding to your question quickly.
I hope this clarifies the stance.
History
Date User Action Args
2020-06-08 17:16:41orsenthilsetrecipients: + orsenthil, benjamin.peterson, ned.deily, r.david.murray, lukasz.langa, mgorny, martin.panter, Björn.Lindqvist, Tim.Graham, miss-islington, roguelazer, Chris Dent
2020-06-08 17:16:41orsenthilsetmessageid: <1591636601.6.0.614336066997.issue27657@roundup.psfhosted.org>
2020-06-08 17:16:41orsenthillinkissue27657 messages
2020-06-08 17:16:41orsenthilcreate