Message370868
> So, we can't rely on checking ``self.done() and self._cancel_requested`` for future.cancelled() as this would mean that future.cancelled() would return true for a future that fully completed if `future.cancel()` was called after it finished (which is incorrect).
This should be "was called *as* it finished", not "was called *after* it was finished". If gather_future.cancel() is called after the future is `FINISHED`, it will immediately return false since it checks `self.done()` first (https://github.com/python/cpython/blob/b8f67c0923ac85468dfbfd43375e0bbfb6ca50ea/Lib/asyncio/tasks.py#L727). |
|
Date |
User |
Action |
Args |
2020-06-07 03:25:10 | aeros | set | recipients:
+ aeros, asvetlov, yselivanov, timmwagener |
2020-06-07 03:25:10 | aeros | set | messageid: <1591500310.23.0.509296283549.issue40894@roundup.psfhosted.org> |
2020-06-07 03:25:10 | aeros | link | issue40894 messages |
2020-06-07 03:25:10 | aeros | create | |
|