➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author gdr@garethrees.org
Recipients docs@python, gdr@garethrees.org, terry.reedy
Date 2020-05-23.08:23:19
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1590222199.75.0.871505352125.issue40707@roundup.psfhosted.org>
In-reply-to
Content 
The following test cases in test_subprocess.py call the communicate() method and then immediately assert that returncode attribute has the expected value:

* test_stdout_none
* test_stderr_redirect_with_no_stdout_redirect
* test_stdout_filedes_of_stdout
* test_communicate_stdin
* test_universal_newlines_communicate_stdin
* test_universal_newlines_communicate_input_none
* test_universal_newlines_communicate_stdin_stdout_stderr
* test_nonexisting_with_pipes
* test_wait_when_sigchild_ignored
* test_startupinfo_copy
* test_close_fds_with_stdio
* test_communicate_stdin

You'll see that some of these test for success (returncode == 0) and some for failure (returncode == 1). This seems like adequate test coverage to me, but if something is missing, let me know.
History
Date User Action Args
2020-05-23 08:23:19gdr@garethrees.orgsetrecipients: + gdr@garethrees.org, terry.reedy, docs@python
2020-05-23 08:23:19gdr@garethrees.orgsetmessageid: <1590222199.75.0.871505352125.issue40707@roundup.psfhosted.org>
2020-05-23 08:23:19gdr@garethrees.orglinkissue40707 messages
2020-05-23 08:23:19gdr@garethrees.orgcreate