Author Dennis Sweeney
Recipients Dennis Sweeney, chris.jerdonek, xtreak
Date 2020-05-20.21:29:25
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1590010165.96.0.874402403321.issue40679@roundup.psfhosted.org>
In-reply-to
Content
I just ran the entire test suite with:

--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -4179,6 +4179,7 @@ _PyEval_EvalCode(PyThreadState *tstate,
         Py_ssize_t j;

         if (keyword == NULL || !PyUnicode_Check(keyword)) {
+            printf("THIS CODE WAS RUN!\n");
             _PyErr_Format(tstate, PyExc_TypeError,
                           "%U() keywords must be strings",
                           qualname);

and the line was never printed. So maybe the test coverage (or removal?) should be a separate issue.
History
Date User Action Args
2020-05-20 21:29:26Dennis Sweeneysetrecipients: + Dennis Sweeney, chris.jerdonek, xtreak
2020-05-20 21:29:25Dennis Sweeneysetmessageid: <1590010165.96.0.874402403321.issue40679@roundup.psfhosted.org>
2020-05-20 21:29:25Dennis Sweeneylinkissue40679 messages
2020-05-20 21:29:25Dennis Sweeneycreate