Message 368425 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	chris.jerdonek
Recipients	asvetlov, chris.jerdonek, yselivanov
Date	2020-05-08.07:40:02
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1588923603.03.0.898484918662.issue40559@roundup.psfhosted.org>
In-reply-to

Content
There is a missing Py_DECREF in task_step_impl() in _asynciomodule.c: https://github.com/python/cpython/blob/02fa0ea9c1073e4476c9bde3d7112f5dd964aa57/Modules/_asynciomodule.c#L2641 It should have the form: if (clear_exc) { Py_DECREF(exc); } This was introduced here in 3.7: https://github.com/python/cpython/commit/bca4939d806170c3ca5d05f23710d11a8f1669cf I'm not sure of the likelihood of this ever getting triggered (it appears to be unlikely), but it should still be addressed. I will file a patch shortly.

There is a missing Py_DECREF in task_step_impl() in _asynciomodule.c:
https://github.com/python/cpython/blob/02fa0ea9c1073e4476c9bde3d7112f5dd964aa57/Modules/_asynciomodule.c#L2641

It should have the form:

    if (clear_exc) {
        Py_DECREF(exc);
    }

This was introduced here in 3.7:
https://github.com/python/cpython/commit/bca4939d806170c3ca5d05f23710d11a8f1669cf

I'm not sure of the likelihood of this ever getting triggered (it appears to be unlikely), but it should still be addressed.

I will file a patch shortly.

History
Date	User	Action	Args
2020-05-08 07:40:03	chris.jerdonek	set	recipients: + chris.jerdonek, asvetlov, yselivanov
2020-05-08 07:40:03	chris.jerdonek	set	messageid: <1588923603.03.0.898484918662.issue40559@roundup.psfhosted.org>
2020-05-08 07:40:03	chris.jerdonek	link	issue40559 messages
2020-05-08 07:40:02	chris.jerdonek	create