Author vstinner
Recipients corona10, pablogsal, phsilva, skrah, vstinner
Date 2020-03-29.14:17:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1585491422.71.0.959760650224.issue40077@roundup.psfhosted.org>
In-reply-to
Content
IMO 1.01x slower on a *microbenchmark* is not significant so it's ok. Thanks for checking.

You pass a *type to isinstance() in bench_isinstance_check.py. You should pass *an instance* instead. Like (complete the (...) ;-)):

runner.timeit(name="bench _abc_instancecheck",
              stmt="isinstance(obj, T)",
              setup = """from abc import ABC (...) obj = (1, 2, 3)""")

Would you mind to fix your microbenchmark and re-run it?
History
Date User Action Args
2020-03-29 14:17:02vstinnersetrecipients: + vstinner, phsilva, skrah, corona10, pablogsal
2020-03-29 14:17:02vstinnersetmessageid: <1585491422.71.0.959760650224.issue40077@roundup.psfhosted.org>
2020-03-29 14:17:02vstinnerlinkissue40077 messages
2020-03-29 14:17:02vstinnercreate