Author zach.ware
Recipients belopolsky, eric.araujo, miss-islington, pdonis, zach.ware
Date 2020-03-26.16:26:07
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1585239967.38.0.221134227539.issue1812@roundup.psfhosted.org>
In-reply-to
Content
12 years later, we finally landed your fix :).  Thanks for the patch, and for bearing with us (and me in particular for the past couple months).

As mentioned in the PR, there is probably opportunity to clean up the cleanup code in the new test a bit, and as √Čric and Ammar mentioned here and in review, it could be interesting to use TextIOWrapper instead (though we'd probably only make that change in 3.9).  If you're interesting in doing a follow-up PR, it can either be attached to this issue (in spite of it being closed) or a new issue opened.
History
Date User Action Args
2020-03-26 16:26:07zach.waresetrecipients: + zach.ware, belopolsky, pdonis, eric.araujo, miss-islington
2020-03-26 16:26:07zach.waresetmessageid: <1585239967.38.0.221134227539.issue1812@roundup.psfhosted.org>
2020-03-26 16:26:07zach.warelinkissue1812 messages
2020-03-26 16:26:07zach.warecreate