Author barneygale
Recipients barneygale, serhiy.storchaka
Date 2020-03-08.09:46:59
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1583660820.05.0.861616323934.issue39899@roundup.psfhosted.org>
In-reply-to
Content
I see no reason for the duplication, and I can point to one concrete bug affecting your re-implementation of `expanduser` that doesn't affect the original, i.e. that a `KeyError` is raised on Windows when `"USERNAME"` is not present in `os.environ`, whereas all similar cases raise `RuntimeError`. These sorts of issues sneak in when you duplicate code - better to stick with the battle-hardened version rather than an inherently risky rewrite.
History
Date User Action Args
2020-03-08 09:47:00barneygalesetrecipients: + barneygale, serhiy.storchaka
2020-03-08 09:47:00barneygalesetmessageid: <1583660820.05.0.861616323934.issue39899@roundup.psfhosted.org>
2020-03-08 09:47:00barneygalelinkissue39899 messages
2020-03-08 09:46:59barneygalecreate