Author gregory.p.smith
Recipients Erik.Tollerud, amaury.forgeotdarc, eric.araujo, eric.snow, gregory.p.smith, meador.inge, miss-islington, psimons, python-dev, serhiy.storchaka, tomdzk
Date 2020-03-05.00:50:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1583369455.73.0.882095579906.issue13487@roundup.psfhosted.org>
In-reply-to
Content
Testing by changing list(sys.modules.items()) to sys.modules.copy().items() internally with a large integration test that was reliably flaky on this line before shows that the .copy().items() worked.  The test is reliable again.

So I've gone ahead and pushed those changes in.  PyDict_Copy()'s implementation at first ~5 minute glance did not appear to have calls to code I'd expect to re-enter Python releasing the GIL.  But I didn't try to do a deep dive.  It works for us and is logically equivalent.
History
Date User Action Args
2020-03-05 00:50:55gregory.p.smithsetrecipients: + gregory.p.smith, amaury.forgeotdarc, eric.araujo, meador.inge, python-dev, eric.snow, Erik.Tollerud, serhiy.storchaka, psimons, tomdzk, miss-islington
2020-03-05 00:50:55gregory.p.smithsetmessageid: <1583369455.73.0.882095579906.issue13487@roundup.psfhosted.org>
2020-03-05 00:50:55gregory.p.smithlinkissue13487 messages
2020-03-05 00:50:55gregory.p.smithcreate