This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Dima.Tisnek
Recipients Ben.Darnell, Dima.Tisnek, Safihre, christian.heimes, gregory.p.smith, martin.panter, nikratio, shevis, xgdomingo
Date 2020-03-04.06:50:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1583304639.8.0.408713594036.issue31122@roundup.psfhosted.org>
In-reply-to
Content
I've traced it down to here: https://github.com/python/cpython/blob/be501ca2419a91546dea85ef4f36945545458589/Modules/_ssl.c#L791-L798

`err.c` (errno) == 0, no error, and `err.ssl` == 5, SSL_ERROR_SYSCALL, helpfully commented "look at error stack/return value/errno" in openssl/ssl.h 😅

I'm a bit suspicious about `s->errorhandler()` which is some old convention (git blame: 8 years ago), commented "checks errno, returns NULL, set a Python exception", but at this point, we know that errno is 0, so why call it?

I'm thinking to just change that to SSLEOFError, but I wonder if something else might break?
History
Date User Action Args
2020-03-04 06:50:39Dima.Tisneksetrecipients: + Dima.Tisnek, gregory.p.smith, christian.heimes, nikratio, Ben.Darnell, martin.panter, Safihre, xgdomingo, shevis
2020-03-04 06:50:39Dima.Tisneksetmessageid: <1583304639.8.0.408713594036.issue31122@roundup.psfhosted.org>
2020-03-04 06:50:39Dima.Tisneklinkissue31122 messages
2020-03-04 06:50:39Dima.Tisnekcreate