Message363329
I've traced it down to here: https://github.com/python/cpython/blob/be501ca2419a91546dea85ef4f36945545458589/Modules/_ssl.c#L791-L798
`err.c` (errno) == 0, no error, and `err.ssl` == 5, SSL_ERROR_SYSCALL, helpfully commented "look at error stack/return value/errno" in openssl/ssl.h 😅
I'm a bit suspicious about `s->errorhandler()` which is some old convention (git blame: 8 years ago), commented "checks errno, returns NULL, set a Python exception", but at this point, we know that errno is 0, so why call it?
I'm thinking to just change that to SSLEOFError, but I wonder if something else might break? |
|
Date |
User |
Action |
Args |
2020-03-04 06:50:39 | Dima.Tisnek | set | recipients:
+ Dima.Tisnek, gregory.p.smith, christian.heimes, nikratio, Ben.Darnell, martin.panter, Safihre, xgdomingo, shevis |
2020-03-04 06:50:39 | Dima.Tisnek | set | messageid: <1583304639.8.0.408713594036.issue31122@roundup.psfhosted.org> |
2020-03-04 06:50:39 | Dima.Tisnek | link | issue31122 messages |
2020-03-04 06:50:39 | Dima.Tisnek | create | |
|