Author jeff.allen
Recipients BTaskaya, benjamin.peterson, brett.cannon, jeff.allen, pablogsal, shihai1991, yselivanov
Date 2020-02-22.20:35:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1582403732.88.0.230241432679.issue39639@roundup.psfhosted.org>
In-reply-to
Content
Jython uses the reference grammar and ASDL as a way to ensure it is Python we approximate, not some subtly different language. The presence of Suite here gives rise to a class (https://github.com/jythontools/jython/blob/v2.7.2b3/src/org/python/antlr/ast/Suite.java) and we actually use instances of it in the compiler (https://github.com/jythontools/jython/blob/v2.7.2b3/src/org/python/compiler/CodeCompiler.java#L2389).

It is a bit of a wart, to have a Jython-specific type here: somewhat defeating the object of using the same source. I expect there was a good reason: perhaps there was no better way to express the commonality between Interactive and Module. It was all before my involvement.

I would try to avoid needing it in Jython 3, and if we can't, it doesn't look hard to manage the variation our copy. It's not like we copy these files mechanically from from CPython during a build.

+1 on removing it.
History
Date User Action Args
2020-02-22 20:35:32jeff.allensetrecipients: + jeff.allen, brett.cannon, benjamin.peterson, yselivanov, pablogsal, BTaskaya, shihai1991
2020-02-22 20:35:32jeff.allensetmessageid: <1582403732.88.0.230241432679.issue39639@roundup.psfhosted.org>
2020-02-22 20:35:32jeff.allenlinkissue39639 messages
2020-02-22 20:35:32jeff.allencreate