Author cjw296
Recipients cjw296, dino.viehland, xtreak
Date 2020-02-09.20:12:34
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1581279154.57.0.484433210388.issue39551@roundup.psfhosted.org>
In-reply-to
Content
Hmm, the more we get into this, the less comfortable I am of the patch in the PR.

Instead of copying and pasting more code that's likely to get out of sync, could you change the PR to just replace _importer with the correct parts of importlib to support your usecase?

Keep the unit test though, useful to show in mock why the change is needed, and make sure we do something sensible in the backport!
History
Date User Action Args
2020-02-09 20:12:34cjw296setrecipients: + cjw296, dino.viehland, xtreak
2020-02-09 20:12:34cjw296setmessageid: <1581279154.57.0.484433210388.issue39551@roundup.psfhosted.org>
2020-02-09 20:12:34cjw296linkissue39551 messages
2020-02-09 20:12:34cjw296create