Message361200
pysqlite_cursor_executescript currently has the following while loop:
/* execute statement, and ignore results of SELECT statements */
rc = SQLITE_ROW;
while (rc == SQLITE_ROW) {
rc = pysqlite_step(statement, self->connection);
if (PyErr_Occurred()) {
(void)sqlite3_finalize(statement);
goto error;
}
}
This can and should be rewritten as a do-while loop to avoid having to initialize rc to SQLITE_ROW and then check its value knowing that the value check will succeed. |
|
Date |
User |
Action |
Args |
2020-02-02 02:05:21 | alex.henrie | set | recipients:
+ alex.henrie |
2020-02-02 02:05:21 | alex.henrie | set | messageid: <1580609121.79.0.36186029109.issue39523@roundup.psfhosted.org> |
2020-02-02 02:05:21 | alex.henrie | link | issue39523 messages |
2020-02-02 02:05:21 | alex.henrie | create | |
|