Author hroncok
Recipients hroncok, mark.dickinson, vstinner
Date 2020-01-31.19:30:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1580499000.84.0.77530880401.issue39350@roundup.psfhosted.org>
In-reply-to
Content
Naively implementing this code, I'd use isinstance(numerator, int) over type(numerator) is int. Is that strict type check really needed?

I could not find anywhere whether numerator and denominator of numbers.Rational need to be numbers.Integral. I would expect so, however this is not written in the documentation of numbers.Rational. If that's the case, I think checking it for being numbers.Integral and failing hard if not is a reasonable thing to do.
History
Date User Action Args
2020-01-31 19:30:00hroncoksetrecipients: + hroncok, mark.dickinson, vstinner
2020-01-31 19:30:00hroncoksetmessageid: <1580499000.84.0.77530880401.issue39350@roundup.psfhosted.org>
2020-01-31 19:30:00hroncoklinkissue39350 messages
2020-01-31 19:30:00hroncokcreate