Message 360742 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	aeros
Recipients	aeros, asvetlov, lukasz.langa, paul.moore, steve.dower, tim.golden, vstinner, yselivanov, zach.ware
Date	2020-01-27.08:22:16
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1580113336.64.0.44225711945.issue38856@roundup.psfhosted.org>
In-reply-to

Content
> The exception should probably be just ignored. It looks like the "ERROR_NETNAME_DELETED" (win32 error 64) exception is already ignored in multiprocessing's connection.wait(): https://github.com/python/cpython/blob/bccacd19fa7b56dcf2fbfab15992b6b94ab6666b/Lib/multiprocessing/connection.py#L857. Would it be appropriate to ignore it here as well? I think that we should still retain the ConnectionResetError for "ERROR_OPERATION_ABORTED", but just specifically ignore "ERROR_NETNAME_DELETED". Ignoring "ERROR_OPERATION_ABORTED" doesn't seem correct here since it's relied on for cancelling file I/O (see https://docs.microsoft.com/en-us/windows/win32/fileio/canceling-pending-i-o-operations). The patch should be straightforward. I'll test it locally and then open a PR, unless Andrew is currently working on it.

> The exception should probably be just ignored.

It looks like the "ERROR_NETNAME_DELETED" (win32 error 64) exception is already ignored in multiprocessing's connection.wait(): https://github.com/python/cpython/blob/bccacd19fa7b56dcf2fbfab15992b6b94ab6666b/Lib/multiprocessing/connection.py#L857. Would it be appropriate to ignore it here as well?

I think that we should still retain the ConnectionResetError for "ERROR_OPERATION_ABORTED", but just specifically ignore "ERROR_NETNAME_DELETED". Ignoring "ERROR_OPERATION_ABORTED" doesn't seem correct here since it's relied on for cancelling file I/O (see https://docs.microsoft.com/en-us/windows/win32/fileio/canceling-pending-i-o-operations).

The patch should be straightforward. I'll test it locally and then open a PR, unless Andrew is currently working on it.

History
Date	User	Action	Args
2020-01-27 08:22:16	aeros	set	recipients: + aeros, paul.moore, vstinner, tim.golden, asvetlov, lukasz.langa, zach.ware, yselivanov, steve.dower
2020-01-27 08:22:16	aeros	set	messageid: <1580113336.64.0.44225711945.issue38856@roundup.psfhosted.org>
2020-01-27 08:22:16	aeros	link	issue38856 messages
2020-01-27 08:22:16	aeros	create