Author SebastianGPedersen
Recipients SebastianGPedersen, corona10, eric.smith, giampaolo.rodola, inada.naoki
Date 2020-01-25.14:03:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1579961025.04.0.408733586319.issue39380@roundup.psfhosted.org>
In-reply-to
Content
Thank you for the feedback.

I will elaborate a little bit on the reasons and thoughts behind the pull request:
Since RFC 2640, the industry standard within FTP Clients is UTF-8 (see e.g. FileZilla here: https://wiki.filezilla-project.org/Character_Encoding, or WinSCP here: https://winscp.net/eng/docs/faq_utf8).

Given this, I believe the majority of the users that have not investigated the code wrongly assumes UTF-8 encoding for ftplib as well (as it is now).

I am new to contributing, and not sure, how much deprecation warnings are used (I simply followed the previous encoding change on ftplib), so I will change it based on the feedback. However, shouldn't it be a FutureWarning, so it will be reported by default at initialisation?
History
Date User Action Args
2020-01-25 14:03:45SebastianGPedersensetrecipients: + SebastianGPedersen, eric.smith, giampaolo.rodola, inada.naoki, corona10
2020-01-25 14:03:45SebastianGPedersensetmessageid: <1579961025.04.0.408733586319.issue39380@roundup.psfhosted.org>
2020-01-25 14:03:45SebastianGPedersenlinkissue39380 messages
2020-01-25 14:03:44SebastianGPedersencreate