Message358552
On Fri, Dec 13, 2019 at 8:08 PM Kyle Stanley <report@bugs.python.org> wrote:
> Yeah, I named it "_PyInterpreterIsFinalizing" and it's within Include/cpython. Definitely open
> to suggestions on the name though, it's basically just a private getter for interp->finalizing.
For a struct-specific getter we usually end the prefix with an
underscore: _PyInterpreter_IsFinalizing. Otherwise, that's the same
name I would have used. :)
> Oh, awesome! In that case, I'll do some more rigorous testing before opening the PR then;
> [snip]
> This might be a bit of a time consuming process, but I should have time in the next week
> or so to work on it.
No worries (or hurries). Just request a review from me when you're
ready. Thanks again for working on this! |
|
Date |
User |
Action |
Args |
2019-12-17 15:52:50 | eric.snow | set | recipients:
+ eric.snow, vstinner, aeros |
2019-12-17 15:52:50 | eric.snow | link | issue37224 messages |
2019-12-17 15:52:49 | eric.snow | create | |
|