Author aeros
Recipients aeros, asvetlov, dacut, larry, lukasz.langa, ned.deily, njs, pitrou, vaizki, xtreak, yselivanov
Date 2019-12-12.07:09:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1576134555.2.0.79190158301.issue37228@roundup.psfhosted.org>
In-reply-to
Content
> One more resource warning about unclosed resource being garbage collected. As per the other tests I think transport and protocol need to be closed as per below patch but someone can verify if it's the right approach.

Ah, good catch. It's not needed when the ValueError occurs because it prevents the transport and protocol from being created in the first place, but I forgot that it would still be needed for the DeprecationWarning test. In addition to your changes, I'll also add a self.assertEqual('CLOSED', protocol.state). This is done in most of the other tests and it doesn't hurt to make sure the protocol properly closed.

I'll add your fix to the PR and add you to the "Co-authored-by" for that commit, thanks.
History
Date User Action Args
2019-12-12 07:09:15aerossetrecipients: + aeros, pitrou, larry, ned.deily, njs, asvetlov, lukasz.langa, yselivanov, dacut, xtreak, vaizki
2019-12-12 07:09:15aerossetmessageid: <1576134555.2.0.79190158301.issue37228@roundup.psfhosted.org>
2019-12-12 07:09:15aeroslinkissue37228 messages
2019-12-12 07:09:14aeroscreate