Author steve.dower
Recipients eryksun, jainankur, lazka, paul.moore, steve.dower, tim.golden, zach.ware
Date 2019-12-02.17:51:35
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1575309096.17.0.0943571748097.issue38948@roundup.psfhosted.org>
In-reply-to
Content
ntpath.ismount() is using a name-only check here, it never tries to resolve the path if splitdrive() returns (anything, one_of("", "/", "\\"))

Now it's not clear whether handling "" is intended there, but that's certainly the difference (Python 2 required exactly one character in that part). And it appears to be consistent back to 3.4, so I'm not sure we can or should fix anything. The only thing 'F:' can ever be is a mount point.

However, we should probably fix the fact that C: returns False. This is because we call abspath(path), and "x:" is a relative path. When the drive does not match the current working drive, you get "x:\\". But when it _does_ match, you get the current working directory, which (unless it's the root directory) is no longer a mount point.

Perhaps the best fix for that is to just say that "x:" is a relative path and hence never a mount point? Which would be the same as switching back to the Python 2 behaviour, but would be a much better reason.
History
Date User Action Args
2019-12-02 17:51:36steve.dowersetrecipients: + steve.dower, paul.moore, tim.golden, zach.ware, eryksun, lazka, jainankur
2019-12-02 17:51:36steve.dowersetmessageid: <1575309096.17.0.0943571748097.issue38948@roundup.psfhosted.org>
2019-12-02 17:51:36steve.dowerlinkissue38948 messages
2019-12-02 17:51:35steve.dowercreate