Author Leandro Lima
Recipients Leandro Lima, christian.heimes, gregory.p.smith, mbussonn, miss-islington, rhettinger
Date 2019-11-27.03:56:03
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
IMV, the adopted solution creates a problem of a mismatch between the signature and the function behavior.

I was just hit by this, as I never cared to specify digestmod trusting that Python defaults are usually sound choices.

I agree that changing the signature would break more code, but the choice made here violates the principle of least astonishment. An error that could be caught by a static analysis tool silently entered the code base to be provoked only when the function got called.

The choice to break compatibility was already made. Introducing silent bugs is something that I think we should avoid.

I've wrote an argument about this in a different message, and I'm not sure if I should repeat it here. Here's the link to it:
Date User Action Args
2019-11-27 03:56:04Leandro Limasetrecipients: + Leandro Lima, rhettinger, gregory.p.smith, christian.heimes, mbussonn, miss-islington
2019-11-27 03:56:04Leandro Limasetmessageid: <>
2019-11-27 03:56:04Leandro Limalinkissue33604 messages
2019-11-27 03:56:03Leandro Limacreate