This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients dhillier, miss-islington, serhiy.storchaka
Date 2019-10-27.10:19:01
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
> I got carried away refactoring the decrypter for a future scenario where there could be different decrypters (possibly using certificates too) :)

The decrypter was implemented with a generator for performance. The performance of decrypting is not critical, but this got us 2x speed up without complicating the code. See issue10030. If the support of other decrypters be added, they will likely be implemented in C in any case.

> I also think that the `read_init` method in my PR is a useful refactor as it locates all the state that needs to be (re)set when starting a read into the same location.

This is a different issue.

> Would you also be able to take a look at some other PRs I've submitted for zipfile.

Thank you, they look good to me. I left just few comments.

As for the original issue, I have doubts that backward seeking in a compressed file is a good idea. But this feature was added, and it worked with encrypted files if seek in the range of the buffer, so not working out of the range of the buffer is a bug which we should fix.
Date User Action Args
2019-10-27 10:19:02serhiy.storchakasetrecipients: + serhiy.storchaka, miss-islington, dhillier
2019-10-27 10:19:02serhiy.storchakasetmessageid: <>
2019-10-27 10:19:02serhiy.storchakalinkissue38334 messages
2019-10-27 10:19:01serhiy.storchakacreate