Author carltongibson
Recipients asvetlov, carltongibson, miss-islington, vstinner, yselivanov
Date 2019-10-23.10:12:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1571825532.43.0.73539907645.issue34687@roundup.psfhosted.org>
In-reply-to
Content
This change causes an issue in asgiref (and so Django) for Windows and Python 3.8. 

https://github.com/django/asgiref/issues/132
https://code.djangoproject.com/ticket/30900

It looks as if `ProactorEventLoop` needs to check the current thread before triggering the signal... 

```
File "C:\Jenkins\workspace\django-windows\database\sqlite3\label\windows\python\Python38\.env\lib\site-packages\asgiref\sync.py", line 130, in _run_event_loop
File "C:\Python38\lib\asyncio\proactor_events.py", line 679, in close
    signal.set_wakeup_fd(-1)
ValueError: set_wakeup_fd only works in main thread
```

... but I'm not familiar with the internals here as yet. 

(I'm guessing I need to create a new issue?)
History
Date User Action Args
2019-10-23 10:12:12carltongibsonsetrecipients: + carltongibson, vstinner, asvetlov, yselivanov, miss-islington
2019-10-23 10:12:12carltongibsonsetmessageid: <1571825532.43.0.73539907645.issue34687@roundup.psfhosted.org>
2019-10-23 10:12:12carltongibsonlinkissue34687 messages
2019-10-23 10:12:12carltongibsoncreate