Author vstinner
Recipients asvetlov, vstinner, yselivanov
Date 2019-10-22.21:58:23
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1571781503.23.0.784560615987.issue38323@roundup.psfhosted.org>
In-reply-to
Content
It seems like MultiLoopChildWatcher doesn't respect the PEP 475: siginterrupt(False) must not be used. But the following change isn't enough to fix this issue (test_close_kill_running hang).

diff --git a/Lib/asyncio/unix_events.py b/Lib/asyncio/unix_events.py
index d8f653045a..887f837bad 100644
--- a/Lib/asyncio/unix_events.py
+++ b/Lib/asyncio/unix_events.py
@@ -1192,9 +1192,6 @@ class MultiLoopChildWatcher(AbstractChildWatcher):
                                "restore to default handler on watcher close.")
                 self._saved_sighandler = signal.SIG_DFL
 
-            # Set SA_RESTART to limit EINTR occurrences.
-            signal.siginterrupt(signal.SIGCHLD, False)
-
     def _do_waitpid_all(self):
         for pid in list(self._callbacks):
             self._do_waitpid(pid)
History
Date User Action Args
2019-10-22 21:58:23vstinnersetrecipients: + vstinner, asvetlov, yselivanov
2019-10-22 21:58:23vstinnersetmessageid: <1571781503.23.0.784560615987.issue38323@roundup.psfhosted.org>
2019-10-22 21:58:23vstinnerlinkissue38323 messages
2019-10-22 21:58:23vstinnercreate