Message 354994 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	ncoghlan
Recipients	ncoghlan, ned.deily, ronaldoussoren, vstinner
Date	2019-10-20.12:26:38
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1571574398.28.0.7198777961.issue30672@roundup.psfhosted.org>
In-reply-to

Content
There are a couple of cases that the C locale coercion tests skip because I don't (or didn't) know what they should do: * https://github.com/python/cpython/blob/24dc2f8c56697f9ee51a4887cf0814b6600c1815/Lib/test/test_c_locale_coercion.py#L262 (skips the "LANG=UTF-8" test) * https://github.com/python/cpython/blob/24dc2f8c56697f9ee51a4887cf0814b6600c1815/Lib/test/test_c_locale_coercion.py#L37 (only adds "POSIX" to the expected C locale equivalents list on non-Android Linux systems) With the interpreter explicitly checking for "POSIX" now, at least the latter special case could potentially be removed, with "POSIX" just always being part of the EXPECTED_C_LOCALE_EQUIVALENTS list. (It was only removed because it used to break on FreeBSD and Mac OS X) I don't think we ever figured out why the "LANG=UTF-8" case didn't work the way we expected, so I suspect where going to need to keep that skip for now.

There are a couple of cases that the C locale coercion tests skip because I don't (or didn't) know what they *should* do:

* https://github.com/python/cpython/blob/24dc2f8c56697f9ee51a4887cf0814b6600c1815/Lib/test/test_c_locale_coercion.py#L262 (skips the "LANG=UTF-8" test)
* https://github.com/python/cpython/blob/24dc2f8c56697f9ee51a4887cf0814b6600c1815/Lib/test/test_c_locale_coercion.py#L37 (only adds "POSIX" to the expected C locale equivalents list on non-Android Linux systems)

With the interpreter explicitly checking for "POSIX" now, at least the latter special case could potentially be removed, with "POSIX" just always being part of the EXPECTED_C_LOCALE_EQUIVALENTS list. (It was only removed because it used to break on FreeBSD and Mac OS X)

I don't think we ever figured out why the "LANG=UTF-8" case didn't work the way we expected, so I suspect where going to need to keep that skip for now.

History
Date	User	Action	Args
2019-10-20 12:26:38	ncoghlan	set	recipients: + ncoghlan, ronaldoussoren, vstinner, ned.deily
2019-10-20 12:26:38	ncoghlan	set	messageid: <1571574398.28.0.7198777961.issue30672@roundup.psfhosted.org>
2019-10-20 12:26:38	ncoghlan	link	issue30672 messages
2019-10-20 12:26:38	ncoghlan	create