Author vstinner
Recipients LorenzMende, ammar2, db3l, eryksun, heckad, miss-islington, paul.moore, skoslowski, steve.dower, tim.golden, vstinner, zach.ware
Date 2019-10-02.20:54:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
> Just an FYI that this change is generating warnings on my Windows 10 buildbot with some regularity about a failure to parse testperf output, such as:

Warning -- Failed to parse typeperf output: '"10/01/2019 07:58:50.056"'

Aha, interesting. I added a warning to debug the code.

> Now, clearly there's no queue length in that output so the parsing warning is accurate, but does the overall build have to reflect a warning in such cases, given that it's just a test harness issue, and not anything going wrong with the actual tests?

The build is marked as "warning" (orange) which is different than "fail" (red). Warnings are used to detect bugs or interesting issues, but not considered as a regression.

> I don't know why both fields aren't present although it seems plausible that it's just a partial line from the I/O (I don't think it guarantees it receives full lines), and the queue length field would appear on the following read.

Right, the code doesn't ensure that a line ends with a newline character. Could you try to run manually the following command to check its output?

   typeperf "\System\Processor Queue Length" -si 1

Maybe uncomplete lines should be buffered in read_output().
Date User Action Args
2019-10-02 20:54:00vstinnersetrecipients: + vstinner, paul.moore, db3l, tim.golden, zach.ware, eryksun, steve.dower, ammar2, miss-islington, LorenzMende, skoslowski, heckad
2019-10-02 20:54:00vstinnersetmessageid: <>
2019-10-02 20:54:00vstinnerlinkissue36670 messages
2019-10-02 20:54:00vstinnercreate