Author tim.peters
Recipients Mark.Shannon, christian.heimes, inada.naoki, jdemeyer, lukasz.langa, miss-islington, nascheme, pablogsal, petr.viktorin, pitrou, tim.peters, vstinner
Date 2019-09-30.18:01:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1569866474.58.0.950002881006.issue38006@roundup.psfhosted.org>
In-reply-to
Content
Yes, it's better to have tp_clear than not for a variety of reasons (including setting examples of best practice).

Best I can tell, the patch for BPO-33418 was reverted _only_ to worm around the crash in _this_ report.  That's no longer needed.  Or, if it is, we've missed something fundamental in the fix for this bug.  In which case, reverting the other patch is the only clear way to find that out quickly.  I favor getting it right.
History
Date User Action Args
2019-09-30 18:01:14tim.peterssetrecipients: + tim.peters, nascheme, pitrou, vstinner, christian.heimes, petr.viktorin, inada.naoki, lukasz.langa, Mark.Shannon, jdemeyer, pablogsal, miss-islington
2019-09-30 18:01:14tim.peterssetmessageid: <1569866474.58.0.950002881006.issue38006@roundup.psfhosted.org>
2019-09-30 18:01:14tim.peterslinkissue38006 messages
2019-09-30 18:01:14tim.peterscreate