Author lisroach
Recipients lisroach, xtreak
Date 2019-09-26.05:05:17
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
Lately I have been having my doubts around having MagicMocks also create AsyncMocks as children. 

Should a MagicMock really have a __aenter__ magic method? 
Is this too far from the original MagicMock if we change child mocks to default not to their parent type, but to their parent type *or* AsyncMock if asynchronous?

It makes the using the mocks easier, since you can just use MagicMock or AsyncMock for whatever you are doing and not think about when to use which. But it also might make the code more confusing, since it isn't as clear when to use one or the other.
Date User Action Args
2019-09-26 05:05:17lisroachsetrecipients: + lisroach, xtreak
2019-09-26 05:05:17lisroachsetmessageid: <>
2019-09-26 05:05:17lisroachlinkissue38163 messages
2019-09-26 05:05:17lisroachcreate