Message 353264 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	lisroach
Recipients	lisroach, xtreak
Date	2019-09-26.05:05:17
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1569474317.72.0.0250414886165.issue38163@roundup.psfhosted.org>
In-reply-to

Content
Lately I have been having my doubts around having MagicMocks also create AsyncMocks as children. Should a MagicMock really have a __aenter__ magic method? Is this too far from the original MagicMock if we change child mocks to default not to their parent type, but to their parent type or AsyncMock if asynchronous? It makes the using the mocks easier, since you can just use MagicMock or AsyncMock for whatever you are doing and not think about when to use which. But it also might make the code more confusing, since it isn't as clear when to use one or the other.

Lately I have been having my doubts around having MagicMocks also create AsyncMocks as children. 

Should a MagicMock really have a __aenter__ magic method? 
Is this too far from the original MagicMock if we change child mocks to default not to their parent type, but to their parent type *or* AsyncMock if asynchronous?

It makes the using the mocks easier, since you can just use MagicMock or AsyncMock for whatever you are doing and not think about when to use which. But it also might make the code more confusing, since it isn't as clear when to use one or the other.

History
Date	User	Action	Args
2019-09-26 05:05:17	lisroach	set	recipients: + lisroach, xtreak
2019-09-26 05:05:17	lisroach	set	messageid: <1569474317.72.0.0250414886165.issue38163@roundup.psfhosted.org>
2019-09-26 05:05:17	lisroach	link	issue38163 messages
2019-09-26 05:05:17	lisroach	create