Message353115
Currently, for the recently added coroutine `loop.shutdown_default_executor()`, the executor shutdown can wait indefinitely for the threads to join. Under normal circumstances, waiting on the threads is appropriate, but there should be a timeout duration in the situation that the threads unable to finish joining.
The motivation for this was based on the comments from Andrew Svetlov and Yury Selivanov in GH-16284.
The original idea from Andrew was to add the timeout duration as a default for a new parameter in `asyncio.run()` and `loop.shutdown_default_executor()`. However, Yury would prefer for this to be defined as a constant instead and not as a parameter for `asyncio.run()` to avoid the creation of an excessive number of parameters to tweak for the user.
I will attach a PR that adds the constant and the parameter for `loop.shutdown_default_executor()`, which will passed as an argument to `thread.join()`. |
|
Date |
User |
Action |
Args |
2019-09-24 19:31:44 | aeros | set | recipients:
+ aeros, asvetlov, yselivanov |
2019-09-24 19:31:44 | aeros | set | messageid: <1569353504.23.0.896727230476.issue38267@roundup.psfhosted.org> |
2019-09-24 19:31:44 | aeros | link | issue38267 messages |
2019-09-24 19:31:43 | aeros | create | |
|