Author jaraco
Recipients ammar2, benjamin.peterson, gregory.p.smith, jaraco, larry, lukasz.langa, mcepl, ned.deily, tburke, webknjaz, xtreak
Date 2019-09-22.16:11:18
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1569168678.52.0.0526742337706.issue38216@roundup.psfhosted.org>
In-reply-to
Content
In https://github.com/cherrypy/cherrypy/pull/1807, I discovered that there is already a fairly straightforward means for a third-party package to override the putrequest character validation (just monkeypatch http.client._contains_disallowed_url_pchar_re with a less strict pattern; I used `[\n]`). This approach is barely worse than the proposal I made in the PR, the main differences being that a monkeypatch of that global variable is global (not selective to specific instances or subclasses of HTTPConnection) and doesn't have any tests in the CPython test suite to protect that as a supported mechanism.
History
Date User Action Args
2019-09-22 16:11:18jaracosetrecipients: + jaraco, gregory.p.smith, larry, benjamin.peterson, ned.deily, mcepl, lukasz.langa, webknjaz, ammar2, tburke, xtreak
2019-09-22 16:11:18jaracosetmessageid: <1569168678.52.0.0526742337706.issue38216@roundup.psfhosted.org>
2019-09-22 16:11:18jaracolinkissue38216 messages
2019-09-22 16:11:18jaracocreate