Author aeros
Recipients aeros, eric.snow, vstinner
Date 2019-09-16.05:15:01
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1568610902.12.0.835140333134.issue37224@roundup.psfhosted.org>
In-reply-to
Content
Upon digging through Modules/_xxsubinterpretersmodule.c, I noticed that on line 2059, `PyInterpreterState_Delete(interp);` is commented out (https://github.com/python/cpython/blob/bf169915ecdd42329726104278eb723a7dda2736/Modules/_xxsubinterpretersmodule.c#L2059). 

This was done when _xxsubinterpretersmodule.c was first added by Eric Snow (https://github.com/python/cpython/blob/bf169915ecdd42329726104278eb723a7dda2736/Modules/_xxsubinterpretersmodule.c#L2059), so it seems to have been done intentionally but I don't understand why.

Is this because `Py_EndInterpreter()` is supposed to shutdown the interpreter, so `PyInterpreterState_Delete()` isn't needed? If so, that still doesn't particularly explain why it was commented out. Perhaps Eric can elaborate.
History
Date User Action Args
2019-09-16 05:15:02aerossetrecipients: + aeros, vstinner, eric.snow
2019-09-16 05:15:02aerossetmessageid: <1568610902.12.0.835140333134.issue37224@roundup.psfhosted.org>
2019-09-16 05:15:01aeroslinkissue37224 messages
2019-09-16 05:15:01aeroscreate