Message352465
There is a memory leak in comparison of sqlite.Row objects when row descriptors are different. There were not tests for this case.
Also, the code compares the result of PyObject_RichCompare() with Py_True and Py_False. It is better to avoid such code, because technically PyObject_RichCompare() can return an arbitrary value, although in this particular case description can only be tuple or None (or NULL, but this is other issue).
Also, there is a test for inequality of hash codes. Since hashes depend on hashes of strings, they value is random, and there is a small chance of failure. Hashes should not be tested for inequality. |
|
Date |
User |
Action |
Args |
2019-09-15 07:29:07 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, ghaering, berker.peksag |
2019-09-15 07:29:07 | serhiy.storchaka | set | messageid: <1568532547.02.0.11116376901.issue38175@roundup.psfhosted.org> |
2019-09-15 07:29:06 | serhiy.storchaka | link | issue38175 messages |
2019-09-15 07:29:06 | serhiy.storchaka | create | |
|