Author serhiy.storchaka
Recipients berker.peksag, ghaering, serhiy.storchaka
Date 2019-09-15.07:29:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1568532547.02.0.11116376901.issue38175@roundup.psfhosted.org>
In-reply-to
Content
There is a memory leak in comparison of sqlite.Row objects when row descriptors are different. There were not tests for this case.

Also, the code compares the result of PyObject_RichCompare() with Py_True and Py_False. It is better to avoid such code, because technically PyObject_RichCompare() can return an arbitrary value, although in this particular case description can only be tuple or None (or NULL, but this is other issue).

Also, there is a test for inequality of hash codes. Since hashes depend on hashes of strings, they value is random, and there is a small chance of failure. Hashes should not be tested for inequality.
History
Date User Action Args
2019-09-15 07:29:07serhiy.storchakasetrecipients: + serhiy.storchaka, ghaering, berker.peksag
2019-09-15 07:29:07serhiy.storchakasetmessageid: <1568532547.02.0.11116376901.issue38175@roundup.psfhosted.org>
2019-09-15 07:29:06serhiy.storchakalinkissue38175 messages
2019-09-15 07:29:06serhiy.storchakacreate