Author lisroach
Recipients cjw296, ezio.melotti, lisroach, michael.foord, xtreak
Date 2019-09-12.12:40:20
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1568292020.39.0.826451235958.issue38136@roundup.psfhosted.org>
In-reply-to
Content
After some discussion about call_count vs await_count, I believe call_count should be counting when things are *awaited* (await foo()), not when they are *called* (foo()). 

I think people expect "calling" to execute the code and give them a return_value, which for asyncio is what happens when you await, not when you call with (). If people disagree about this I am open to discussion, we can change the current functionality and leave in the assert_awaited_* calls.

Currently the code does count asyncio calls when they are awaited, but this makes the assert_awaited_* calls redundant. 

We should remove these in favor of the call_count_* functions.
History
Date User Action Args
2019-09-12 12:40:20lisroachsetrecipients: + lisroach, cjw296, ezio.melotti, michael.foord, xtreak
2019-09-12 12:40:20lisroachsetmessageid: <1568292020.39.0.826451235958.issue38136@roundup.psfhosted.org>
2019-09-12 12:40:20lisroachlinkissue38136 messages
2019-09-12 12:40:20lisroachcreate