Message352144
After some discussion about call_count vs await_count, I believe call_count should be counting when things are *awaited* (await foo()), not when they are *called* (foo()).
I think people expect "calling" to execute the code and give them a return_value, which for asyncio is what happens when you await, not when you call with (). If people disagree about this I am open to discussion, we can change the current functionality and leave in the assert_awaited_* calls.
Currently the code does count asyncio calls when they are awaited, but this makes the assert_awaited_* calls redundant.
We should remove these in favor of the call_count_* functions. |
|
Date |
User |
Action |
Args |
2019-09-12 12:40:20 | lisroach | set | recipients:
+ lisroach, cjw296, ezio.melotti, michael.foord, xtreak |
2019-09-12 12:40:20 | lisroach | set | messageid: <1568292020.39.0.826451235958.issue38136@roundup.psfhosted.org> |
2019-09-12 12:40:20 | lisroach | link | issue38136 messages |
2019-09-12 12:40:20 | lisroach | create | |
|