This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author xtreak
Recipients cjw296, lisroach, mariocj89, michael.foord, xtreak
Date 2019-09-09.10:50:23
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1568026223.93.0.545464297225.issue37383@roundup.psfhosted.org>
In-reply-to
Content
> I wonder if `await_count` is really necessary, since it is essentially the same as `call_count`. Would it be too late or confusing to remove it now?

IMO if we are to document that mock_calls is recorded over await then we can have both call_count and await_count because if users start using AsyncMock then they can keep using the call_* functions. Removing it would mean there are also other counterparts as below to make sure we keep or remove all to remove discrepancy. I am more leaned towards keeping them and document it.

>>> m.await
m.await_args      m.await_args_list m.await_count     m.awaited
>>> m.call
m.call_args      m.call_args_list m.call_count     m.called

With respect to removal I think the window is still open till the 3.8.0RC1.
History
Date User Action Args
2019-09-09 10:50:23xtreaksetrecipients: + xtreak, cjw296, michael.foord, lisroach, mariocj89
2019-09-09 10:50:23xtreaksetmessageid: <1568026223.93.0.545464297225.issue37383@roundup.psfhosted.org>
2019-09-09 10:50:23xtreaklinkissue37383 messages
2019-09-09 10:50:23xtreakcreate