Author p-ganssle
Recipients belopolsky, berker.peksag, bmispelon, corona10, p-ganssle, rhettinger, serhiy.storchaka, taleinat, tim.peters, vstinner
Date 2019-09-03.18:15:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1567534510.12.0.198477397541.issue24416@roundup.psfhosted.org>
In-reply-to
Content
In an effort to get a sense of how useful this would actually be, I did a code search for `.isoformat()` on github. I saw a few doctests that will break (if they're even being run) if we make this change, but I also found that the *vast* majority of uses of `isocalendar` seem to be people pulling out a single component of it, like:  `return datetime.datetime.now().isocalendar()[1]`.

That is not the kind of usage pattern I was envisioning when I said that this was a marginal improvement, a *lot* of this code could be made considerably more readable with named fields. If indeed the performance is similar or the same and this won't impact consumers of the pure python version of the module unduly (I checked in #pypy and they think that it shouldn't be more than a minor irritation if anything), then I am changing my -1 to a +1.
History
Date User Action Args
2019-09-03 18:15:10p-gansslesetrecipients: + p-ganssle, tim.peters, rhettinger, belopolsky, vstinner, taleinat, berker.peksag, serhiy.storchaka, bmispelon, corona10
2019-09-03 18:15:10p-gansslesetmessageid: <1567534510.12.0.198477397541.issue24416@roundup.psfhosted.org>
2019-09-03 18:15:10p-gansslelinkissue24416 messages
2019-09-03 18:15:09p-gansslecreate