Author ncoghlan
Recipients ncoghlan, pablogsal
Date 2019-08-29.12:22:43
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1567081363.27.0.964919099007.issue37947@roundup.psfhosted.org>
In-reply-to
Content
Reviewing the PR post-merge, I'm pretty sure this has introduced a double-decrement bug due to the original code being hard to read (the error cases did the decrement inside the helper function, while the success case did it in the calling function).

https://github.com/python/cpython/pull/15593 builds on your PR by removing the recursion counter adjustments from inside the helper function, leaving only the ones in the calling function.
History
Date User Action Args
2019-08-29 12:22:43ncoghlansetrecipients: + ncoghlan, pablogsal
2019-08-29 12:22:43ncoghlansetmessageid: <1567081363.27.0.964919099007.issue37947@roundup.psfhosted.org>
2019-08-29 12:22:43ncoghlanlinkissue37947 messages
2019-08-29 12:22:43ncoghlancreate